search

pstolarz / OneWireNg

Arduino 1-wire service library. OneWire compatible. Dallas thermometers support.
BSD 2-Clause "Simplified" License
85 stars 19 forks source link

ESP32: add attributes IRAM #37

Closed uzi18 closed 2 years ago

uzi18 commented 2 years ago

here you are :)

pstolarz commented 2 years ago

Have you checked the change on your setups (ESP32, ESP8266)? Basically I'm not opposite to this change, although don't expect drastic timing improvements (OneWireNg_BitBang::reset() and OneWireNg_BitBang::touchBit() are already IRAMed for both ESPs). I'll need to check this change with OD mode on my setups before a marge.

pstolarz commented 2 years ago

Let it go, I'll check it later...

uzi18 commented 2 years ago

No but I'm sure about it is absolutely must and some OneWire forks exists only because of this change

pstolarz commented 2 years ago

I haven't got any issues for the lib w/o this attribute. As I said reset() and touchBit() are already IRAMed. But ok, I merged it and will test it probably in the next weekend (especially for the over-drive mode).