search

psu-capstone / churchill

Other
2 stars 2 forks source link

extend submit button on rankings to span the width of the tabset #99

Closed m-d-s closed 8 years ago

m-d-s commented 8 years ago

maybe play around with the styling a little as well

m-d-s commented 8 years ago

I saw you pushed a branch up for this, were you trying to get that merged in? If so, you generally need to open a pull request so that I know you are done working on the branch. If not, feel free to keep working on it

lafertej commented 8 years ago

I was going to do one or two more things since the changes I made were pretty small. Or should I try to merge with each thing/more often? On Feb 7, 2016 9:50 AM, "m-d-s" notifications@github.com wrote:

I saw you pushed a branch up for this, were you trying to get that merged in? If so, you generally need to open a pull request so that I know you are done working on the branch. If not, feel free to keep working on it

— Reply to this email directly or view it on GitHub https://github.com/psu-capstone/churchill/issues/99#issuecomment-181061249 .

m-d-s commented 8 years ago

Pushing your changes up regularly is usually a good idea, you would only try to merge via a pull request when you believe your issue is complete.

lafertej commented 8 years ago

That's what I mean, are you wanting me to pull request between issues even though they're so small? On Feb 7, 2016 2:14 PM, "m-d-s" notifications@github.com wrote:

Pushing your changes up regularly is usually a good idea, you would only try to merge via a pull request when you believe your issue is complete.

— Reply to this email directly or view it on GitHub https://github.com/psu-capstone/churchill/issues/99#issuecomment-181133395 .