Override Valkyrie::Persistence::Shared::JSONValueMapper::DateValue

psu-libraries / cho

Project for Penn State Library's cultural heritage object repository.

Apache License 2.0

18 stars 2 forks source link

Override Valkyrie::Persistence::Shared::JSONValueMapper::DateValue #1038

Closed awead closed 5 years ago

awead commented 5 years ago

Description

Allows iso8601 dates that do not have time stamps, such as 1956-12-31, to be returned as strings and not DateTime objects. This allow for EDTF date-style processing at other points in the application.

Connected to #1035

awead commented 5 years ago

@rschenk This is more of a "band-aid" approach that hopefully just unblocks us. It's definitely a bug in Valkyrie, which should not be casting unwitting strings into dates, but that's another matter. There's a more elegant solution to be had in there, at a later date.

coveralls commented 5 years ago

Coverage increased (+0.001%) to 99.464% when pulling bbb9837fa6c0823e3f54a55c859e62070e799bf3 on edtf-band-aid into d3eff53e48e3a915eae57b87d235f40d8d47cbe9 on master.