piwik id is configurable by application.yml

psu-libraries / cho

Project for Penn State Library's cultural heritage object repository.

Apache License 2.0

18 stars 2 forks source link

piwik id is configurable by application.yml #1042

Closed rschenk closed 5 years ago

rschenk commented 5 years ago

Description

Piwik id had been hard-coded to 2. It is now configurable via application.yml

In order for this to take effect, we will need to talk to the devops folks. The following key-value should be added to application.yml in chef on the following servers

# QA
piwik_id: '2'

# Stage
piwik_id: '5'

# Production
piwik_id: '6'

(Note that Figaro likes all values to be strings)

Connected to #951

coveralls commented 5 years ago

Coverage remained the same at 99.43% when pulling a074f0293bf22f076a01544b8ce7c33225e52de4 on i#951-config-piwik-id into 850ee653c2f34ac0c4351457d85cf6f9c2685176 on master.

awead commented 5 years ago

I'll try pushing this branch to QA and see if it clears. If so, we can merge this.

awead commented 5 years ago

Looks like this is working as expected. If I deploy to qa without the id in the yaml file, I get:

Repository::Configuration::Error: piwik_id is a required key in application.yml

If I add the value on the server, it deploys and is set correctly.