psu-libraries / cho

Project for Penn State Library's cultural heritage object repository.
Apache License 2.0
18 stars 2 forks source link

Look and Feel Cleanup for Collection Pages #1050

Closed mtribone closed 5 years ago

mtribone commented 5 years ago

Makes accessibility, layout adjustments to the collection search bar to bring it closer to the mockup without creating a new collection landing page. Wraps the collection search in a fieldset with a legend.

Updates the tests for heading hierarchy and adjusted content.

Adds classes and divs for the presentation of the collection title and the browse button and finding aid link

Description

Another round of styling and functionality to get a little further towards the customization path with UI elements and the Collection pages.

Connected to #960 #997

Changes

mtribone commented 5 years ago

Default image is the library, for now, until we can come up with something cooler.

Screen Shot 2019-06-20 at 8 28 58 AM

mtribone commented 5 years ago

Default image carries over to the browse page.

Screen Shot 2019-06-20 at 8 41 05 AM

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 99.439% when pulling 259ae043d9af89dcd83325aacdb6e57f8aecf903 on i#960-look-fix into 40fe2797303aa0ec0d76bbb22838474f6129f037 on master.

mtribone commented 5 years ago

When I add an image with the same ID as the collection into the public/collection-images folder something magical happens.

Screen Shot 2019-06-20 at 8 47 41 AM

mtribone commented 5 years ago

And the magic carries through to the browse page.

Screen Shot 2019-06-20 at 8 47 56 AM

rschenk commented 5 years ago

I like it! I do think it'd be worth taking another iteration at "flexboxing" the title/buttons/image but I think what we've got is good