search

psu-libraries / myaccount

My Account - an application for checkouts, renewals, holds and bills
Apache License 2.0
0 stars 0 forks source link

error "code"=>"beingFilled" #340

Open cdmo opened 3 years ago

cdmo commented 3 years ago

Jan 11 10:00:36 L5bcapp02prod.vmhost.psu.edu sidekiq: 2021-01-11T15:00:36.698Z pid=27402 tid=otafegwq6 class=ChangePickupByDateJob jid=08156441fa320b3ee114f4a0 ERROR: pickup_by_date_3972070: {"messageList"=>[{"code"=>"beingFilled", "message"=>"The fillByDate for this request cannot be edited at this time because it is already in the process of being filled."}]}

https://app.datadoghq.com/apm/trace/4330986092317069574?spanID=2374386188483611811&env=production&sort=time&colorBy=service&spanViewType=metadata&graphType=flamegraph&shouldShowLegend=true

Error 400: [{"code"=>"beingFilled", "message"=>"The fillByDate for this request cannot be edited at this time because it is already in the process of being filled."}]

https://app.datadoghq.com/apm/trace/1794092664249146018?colorBy=service&env=production&graphType=flamegraph&shouldShowLegend=true&sort=desc&spanID=283198068775497228&spanViewType=metadata&timeHint=1631555464925.7979

cdmo commented 3 years ago

asked maryam about this earlier today, will see if she has any feedback. know she is busy with meetings

banukutlu commented 3 years ago

Sirsi's response :

The pickup date for a hold is ONLY generated once the item is trapped to fill the hold. User should not be able to extend that, as it prevents other users from being able to fill their holds on the same item

Asking Sirsi if there a way to determine if a hold is beingFilled before attempting to change the fillByDate? Some field on a hold that indicated this.