search

psu-libraries / psulib_base

Drupal Base Theme
0 stars 0 forks source link

11 mixins and breakpoints #27

Closed schwent closed 4 months ago

schwent commented 4 months ago

I added the breakpoints from Bootstrap's repo. I'm not sure we need this file if it comes from the core _variables.scss file. Need guidance here. Thanks!

chrisdarke42 commented 4 months ago

So you don't need to include the mixins if they are already in Bootstrap. The idea of declaring the breakpoints is that if there are different breakpoints from the bootstrap defaults, then those need to be defined. If however you are all just using bootstrap default breakpoints then there is no need for this.

schwent commented 4 months ago

Yes, that is what I was thinking. This could evolve to include other breakpoints as we theme our sites, but it's hard to say what those will be - that work for all sites - at this moment.

chrisdarke42 commented 4 months ago

Not needed as this is all being brought in via bootstrap