psu-libraries / psulib_base

Drupal Base Theme
0 stars 0 forks source link

empty out base js #34

Closed whereismyjetpack closed 6 months ago

whereismyjetpack commented 6 months ago

this js was example js from the drush skaffolding, and doesn't resolve

image

when compiling javascript, this throws an exception early and no later javascript loads properly

cjwetherington commented 6 months ago

@whereismyjetpack So is this related to #31, or not so much? I'm unsure whether I'm reading your background comment above correctly.

whereismyjetpack commented 6 months ago

I don't have enough information to say if this will or won't fix it, but it never hurts to remove unused code :)

cjwetherington commented 6 months ago

I don't have enough information to say if this will or won't fix it, but it never hurts to remove unused code :)

It doesn't fix it, at least not based on my quick testing, but I think it gives me a clue, so thank you!

EDIT: I take that back, this was the root of the problem requiring #31, I think. @chrisdarke42 let me know if you think it's better to now roll those dependencies out of the libraries.yml or if they're worth keeping around for good measure.