In the User#needs_open_access_notification filter, let's remove the activity_insight_postprint_statuswhere clause:
.where('publications.activity_insight_postprint_status IS NULL OR publications.activity_insight_postprint_status != ?', 'In Progress')
And instead, filter out any publication that has an associated Activity Insight OA File.
@anaelizabethenriquez If a user does receive an OA notification email (for a different publication that does not have an Activity Insight OA File) should publications with Activity Insight OA Files be filtered out of the email? We don't currently filter out publications with a post print status of "In Progress" from these emails.
@ajkiessl Yes! The publications with Activity Insight OA Files should be filtered out of the email text (in addition to not triggering an email). This probably explains most/all of what I noticed in #1005.
In the
User#needs_open_access_notification
filter, let's remove theactivity_insight_postprint_status
where
clause:.where('publications.activity_insight_postprint_status IS NULL OR publications.activity_insight_postprint_status != ?', 'In Progress')
And instead, filter out any publication that has an associated Activity Insight OA File.
@anaelizabethenriquez If a user does receive an OA notification email (for a different publication that does not have an Activity Insight OA File) should publications with Activity Insight OA Files be filtered out of the email? We don't currently filter out publications with a post print status of "In Progress" from these emails.