How we are creating Agents for logged in users is a bit scary

psu-libraries / scholarsphere-3

A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)

Apache License 2.0

78 stars 24 forks source link

How we are creating Agents for logged in users is a bit scary #1521

Open carolyncole opened 5 years ago

carolyncole commented 5 years ago

When looking into showing the email and login for the logged in user in the new work form (refs #1453)

We ran into this code: https://github.com/psu-stewardship/scholarsphere/blob/develop/app/services/alias_management_service.rb#L61-L63

We are using this to create the agents for a logged in user. That means for a user who we know the login and email, we are still using the name to differentiate the person.

carolyncole commented 5 years ago

Verify this is addressed by #1453