Downgrade to Ruby 2.4.6

psu-libraries / scholarsphere-3

A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)

Apache License 2.0

78 stars 24 forks source link

Downgrade to Ruby 2.4.6 #1579

Closed awead closed 5 years ago

awead commented 5 years ago

Ruby 2.6 was creating problems with cloud upload that wasn't apparent until regression testing. Ruby 2.5 had a different issue with CSV encoding: https://github.com/ruby/csv/issues/23

We're trying out 2.4 to see if it's any better, but it may still have this issue.

Ruby 2.4 EOL date: 2020-03-31

Connected to #1324

coveralls commented 5 years ago

Coverage decreased (-0.005%) to 58.421% when pulling 7921729861e5cf33049850ef1a1f1a158fad5756 on ruby-2.4 into 5082b9e714a69f051657ff35a496b7cf126ab2c8 on develop.

awead commented 5 years ago

After running the cloud upload regression test, this works. 2.6 was not working with cloud upload, so we'll just have to use 2.4 until we figure out what's going on in 2.6. We have a year...