Add aria-hidden=true to the icons in the toolbar

psu-libraries / scholarsphere-3

A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)

Apache License 2.0

78 stars 24 forks source link

Add aria-hidden=true to the icons in the toolbar #612

Closed mtribone closed 7 years ago

mtribone commented 7 years ago

The font awesome icons in the toolbar should have aria-hidden=true for better accessibility.

screen shot 2017-02-06 at 3 44 59 pm

mtribone commented 7 years ago

Also, we should reduce the top and bottom padding on the toolbar. It's HUGE...believe me...everybody who I talk to says that it is huge...and it's not just my head.

.navbar-nav > li > a in Sufia gets 15px and .nav > li > a in Sufia gets 10px. So like 25px of padding top and bottom.