psy0rz / zfs_autobackup

ZFS autobackup is used to periodicly backup ZFS filesystems to other locations. Easy to use and very reliable.
https://github.com/psy0rz/zfs_autobackup
GNU General Public License v3.0
583 stars 62 forks source link

Getting "No source filesystems selected" when source datasets are correctly tagged but just unchanged #190

Closed githubjsorg closed 1 year ago

githubjsorg commented 1 year ago

In the output, it shows "Excluded (unchanged since last snapshot)" for all tagged source datasets. But at the end it shows "No source filesystems selected" in red. When checking for backup errors, this is alarming and misleading as "source filesystems" are correctly selected, they were just skipped.

zfs-autobackup --version zfs-autobackup v3.1.3 - (c)2021 E.H.Eefting (edwin@datux.nl)

Please let me know if I can provide any additional information or if you would like me to test a fix.

Thank you for this amazing tool simplifying the send/receive process.

psy0rz commented 1 year ago

that sounds like a stupid bug and its weird noone encountered it before, ill look into it :)

psy0rz commented 1 year ago

strange, i cant reproduce it.

can you run the command with --debug and show the full commandline and output?

githubjsorg commented 1 year ago

Command: zfs-autobackup --debug --verbose --exclude-unchanged --clear-refreservation --min-change 42950000000 offsite1 CloudBackup

Note: I used --min-change 42950000000 just to be sure it doesn't find changes for now.

Here is the log:

zfs-autobackup-output.txt

psy0rz commented 1 year ago

i will try this, its very likely that it has that bug.

btw are you use you need exclude-unchanged? normally zfs-autobackup already skips datasets that are unchanged since the last backup.

--exclude-unchanged looks at all the snapshots, not just those created by zfs-autobackup. this is usefull if you have something else running like proxmox HA replication, and you want to exclude those.

githubjsorg commented 1 year ago

Ah. It wasn't clear in the -h output that it already excluded unchanged or that --exclude-unchanged specifically looked at snapshots.

psy0rz commented 1 year ago

it was more work than expected , and i found another bug since it didnt have a regression test yet. Fixed in v3.2-beta2