psy0rz / zfs_autobackup

ZFS autobackup is used to periodicly backup ZFS filesystems to other locations. Easy to use and very reliable.
https://github.com/psy0rz/zfs_autobackup
GNU General Public License v3.0
583 stars 62 forks source link

Create actual manual wiki page #227

Closed psy0rz closed 11 months ago

psy0rz commented 11 months ago

A page that describes all the options and links to other pages.

226 reminded me of that

danboid commented 11 months ago

I was going to improve your docs for you today only to discover the autobackup "Wiki" page isn't a wiki at all because there is no edit button.

I'm surprised github lets you disable the edit feature on the wiki because then its not actually a wiki any more, its a static web page.

danboid commented 11 months ago

The main things I wanted to add was a note about being careful to add exceptions to datasets you don't want to replicate to the --strip-path section before running autobackup for real (ie not in --test mode) and I also wanted to add more detail on how autobackup creates and manages its snapshots which might take the form of a section for those coming from z-a-s or sanoid etc. I won't be the only one who wants to know how autobackup can integrate (or not) into such systems.

The other thing missing from the wiki is a list of the ZFS permissions required on either side when autobackup is running as a non root user. I'm not sure about this myself yet but I suspect it will be the same as what syncoid requires.

psy0rz commented 11 months ago

Sorry, the problem is that if i open the wiki, everyone can edit it and i wont even get a notification about it.

I'm currently working on a reference manual page that descrips all the steps in detail, so we can add your info to that page perhaps.

danboid commented 11 months ago

If you want to vet the docs, move the wiki into the main repo so that users can submit pull requests.

psy0rz commented 11 months ago

i've added you to the colleborators, so you can edit pages now

danboid commented 11 months ago

Thanks!

psy0rz commented 11 months ago

If you want to vet the docs, move the wiki into the main repo so that users can submit pull requests.

how? will it still look like an intergrated wiki?

please be carefull with editing, keeping the same style, and use proper formatting and stuff. :)

psy0rz commented 11 months ago

oh i found this: https://nimblehq.co/blog/create-github-wiki-pull-request

but thats too much hassle for now :)

danboid commented 11 months ago

It wouldn't be a wiki any more if you moved it into the main repo but thats how other projects do it, just use markdown and link to it from the README. A wiki is less hassle and you're likely to get more contributions.

danboid commented 11 months ago

Done!

I've fixed a few typos and grammatical errors and added new "Running without root" and "Use alongside other snapshot tools" sections.

In the ssh section you say "Your user needs read/write access to /dev/zfs and you need to setup zfs permissions as well." I presume the user needing access to /dev/zfs is a FreeBSD only issue as I've never had to do anything with /dev/zfs under Linux to allow normal users to use ZFS?

psy0rz commented 11 months ago

Awesome thanks!

Usually those /dev permissions are ok. But not on all distros.

psy0rz commented 11 months ago

done, maybe you want to review it @danboid

https://github.com/psy0rz/zfs_autobackup/wiki/Manual

Done!

danboid commented 11 months ago

Awesome thanks!

Usually those /dev permissions are ok. But not on all distros.

I've never had to touch /dev/zfs ever under Ubuntu, Debian and Arch derivatives but I didn't know it was a thing until you mentioned it here. I'm pretty sure we don't need to cover it on the wiki.

psy0rz commented 11 months ago

I think the stuff about /dev/zfs can be moved to that new manual page. I already moved the run without root stuff there.

The getting started only should cover the basic usecases, with as little as extra (confusing) info as possible.

Also the layout of the manual is not perfect yet. But ill fix that once i think about it some more

danboid commented 11 months ago

If I use --no-snapshot., what does zfs-autobackup do?

psy0rz commented 11 months ago

Did you not read that manual i just posted??

danboid commented 11 months ago

Every line but this wasn't covered. I could try it out for myself to find out I suppose. I would presume its a no-op?

mduller commented 11 months ago

If I use --no-snapshot., what does zfs-autobackup do?

From https://github.com/psy0rz/zfs_autobackup/wiki/Manual#step-2-snapshotting

Snapshotting can be skipped with --no-snapshot.

Yes, it will turn the snapshotting step into a no-op.

psy0rz commented 11 months ago

Yep it just doesnt create a new snapshot, but it still does everything else.

psy0rz commented 11 months ago

Oh sorry, i see now you where asking because youre actually trying to improve that manual page 😁

danboid commented 11 months ago

I was asking because I see zfs-autobackup as a ZFS snapshot tool so can it even do anything if it hasn't created any of its own snapshots and --no-snapshot is used? I presume it would do nothing if there were no existing snapshots and you ran without --no-snapshot right?

psy0rz commented 11 months ago

If you use it without target-path and with --no-snapshot, it still does the thinning.

But there are indeed valid combinations of parameters that result in not doing anything.