Implement Issue #245 Snapshot exclude patterns

psy0rz / zfs_autobackup

ZFS autobackup is used to periodicly backup ZFS filesystems to other locations. Easy to use and very reliable.

https://github.com/psy0rz/zfs_autobackup

GNU General Public License v3.0

583 stars 62 forks source link

Implement Issue #245 Snapshot exclude patterns #264

Open exi opened 3 weeks ago

exi commented 3 weeks ago

Issue #245

This is mostly a first draft without tests, but it seems to work and i'm using these changes on top of v3.2.2 on my server.

The primary point why I needed this is because in the time zfs_autobackup runs, my zfs-autosnapshot has taken and removed multiple "frequent" snapshots, which leads to autobackup failures. I just want autobackup the snapshots with "monthly", "weekly" and "daily" in the name.

exi commented 3 weeks ago

@psy0rz I just wanted to get early feedback if this approach seems reasonable. I know you don't have much time to implement it yourself, so worst case i'll just use my own patched version on my server for the time being.

psy0rz commented 3 weeks ago

looks good, but "is_exluded" is too generic a name i think?

psy0rz commented 3 weeks ago

uh oohh some tests failed?

psy0rz commented 3 weeks ago

oh nevermind they were already broken, i'll have to fix that first