search

psybuzz / goldenconversations

0 stars 0 forks source link

Hall of Fame Design #50

Closed tonyxj closed 9 years ago

tonyxj commented 9 years ago

image

Hi guys, @psybuzz @nikilselvam I've pushed up the new design with some dummy html. The conversation classes are most the same as the Home page. This PR is the basic foundation for us to build upon for the TOC. In the spirit of keeping tasks short, I'll be adding the Convershapes in another PR. The same regarding the Stats panel, it can be addressed in another PR. However I was thinking perhaps surfacing two numbers for Stats, 1: total conversations participating in, 2: number of conversations saved to HOF.

Is it possible to surface those numbers? What are the time/effort needed to surface them? Having those in mind will help to determine if we can/should build stats right now.

Thanks guys!

nikilselvam commented 9 years ago

This looks good! The color really makes the page stand out. I have a couple of comments related to spacing and wording, but otherwise this LGTM.

With regards to your question about stats @tonyxj , those stats should be relatively pretty easy to surface. Each user has a collection of conversations that they are participating in in the database, and each of these conversations has a boolean indicating whether the user has archived it or not. All we need to do is to iterate through all of these conversations in order to determine how many conversations have been archived in general and how many conversations the user has in total. I think we can do this with a few calls and some processing in the backend! What do you think @psybuzz ?

psybuzz commented 9 years ago

@nikilselvam In regards to stats, I think we can write stats logic on the front-end to do the things you mentioned. In home.js, around line 100, we should be getting all of the user's conversations, so we could simply count them and filter to see how many are in the HoF.

Edit: on second thought, you're right in that we'd need an extra call to the backend. We could do something along the lines of exposing another "/stats" url that handles stats specifically.

psybuzz commented 9 years ago

I noticed that when the browser width is small, the right-pane gets reaallly close to the left pane. Upon inspection, it seems that the right pane as a percentage margin-left. This might not be related to the changes you made, but is this intentional? image

psybuzz commented 9 years ago

Nice changes, @tonyxj ! I had a comment about the copy/writing, but as long as it's concise and readable, I'm down for it. For the stats, it will likely require a separate PR to expose that data, so for now, could you work with some hard-coded, fake numbers? Other than that, LGTM.

tonyxj commented 9 years ago

@psybuzz Nice catch regarding the browser width! That's definitely something I need to address. For now I've inherited the home.scss where this behaviour is also showing. However, adjusting the screen any smaller than that will trigger the mobile view which fixes the margin problem. I'll be tweaking this along with the placeholder number stats in the next PR. Thanks guys!