search

psycharo-zz / factor-graph

matlab/c++ factor graph framework
32 stars 8 forks source link

Are id's needed? #18

Closed ghost closed 11 years ago

ghost commented 11 years ago

In kalman_example, we write, 

>> xin = evidencenode(1); 
>> xout = evidencenode(2);

Why do we need the id? If I exchange the node id's, eg,

>> xin = evidencenode(2); 
>> xout = evidencenode(1);

than the example runs just as well.

The id's are not used later in the code of kalman_example. So the question is if it is possible to hide the id's from the application user, as in

>> xin = evidencenode(); 
>> xout = evidencenode();

or, better yet, see issue #17, 

>> xin = ffg.EvidenceNode(); 
>> xout = ffg.EvidenceNode();
psycharo-zz commented 11 years ago

originally they are very useful for debugging, but yeah, they are not actually necessary