psycharo-zz / factor-graph

matlab/c++ factor graph framework
32 stars 8 forks source link

on testing factor nodes #27

Closed ghost closed 11 years ago

ghost commented 12 years ago

I looked at testEqualityNode and think it's great. good job! Some comments/suggestions:

or, better yet, set m_a=10 and V_a = 5 at the top of the function and work with teh variables. The reason is that I like to see where the EXPECTED_VAR and EXPECTED_MN comes from.

nice job!

psycharo-zz commented 11 years ago

concerning the findAssertion, I guess it would be too much. How about just adding comments like "Loeliger 2007" in the test body and then using Ctrl+F|Ctrl+S?

ghost commented 11 years ago

I'm fine with your resolution on 'findAssertion'.

psycharo-zz commented 11 years ago

Removed all unneeded 'dat' files, all data is generated on-the-fly.