Closed ghost closed 11 years ago
concerning the findAssertion
, I guess it would be too much. How about just adding comments like "Loeliger 2007" in the test body and then using Ctrl+F|Ctrl+S?
I'm fine with your resolution on 'findAssertion'.
Removed all unneeded 'dat' files, all data is generated on-the-fly.
I looked at
testEqualityNode
and think it's great. good job! Some comments/suggestions:In
testEqualityNode
, on line 23, 24, I woudl prefer to seeEXPECTED_VAR = 1/(1/5 + 1/4); EXPECTED_MEAN = EXPECTED_VAR * (10/5 + 20/4) ;
or, better yet, set
m_a=10
andV_a = 5
at the top of the function and work with teh variables. The reason is that I like to see where the EXPECTED_VAR and EXPECTED_MN comes from.findAssertion('Loe2007-II.4')
.testaddNode
has dependencies on other toolbox fucntions likenetwork.addEdge
. In the long term, if the test suite expands this could lead to problems. I dont knwo how to resolve that either. My colleage Joris here has a matlab tool calledmuice
that's basically the matlab equivalent of this: http://code.google.com/p/google-guice/ (has something to do with dependency injection. Let me know if you want ot know more.nice job!