psycharo-zz / factor-graph

matlab/c++ factor graph framework
32 stars 8 forks source link

defining where mex is in Makefile.win64 #29

Closed ghost closed 12 years ago

ghost commented 12 years ago

This first line in line Makefile.win64

MEX = C:\Program Files\MATLAB\R2012a\bin\mex.bat

works for rlease 2012a but shoudl also work for other releases.

psycharo-zz commented 12 years ago

well strictly speaking this is not a bug, the user has to specify the toolbox he is using. windows does not provide any decent tools for that.

ghost commented 12 years ago

OK, agreed, good point. My question is then if it's possible for make to accept an argument, like the matlab version (2012b, 2012a, etc) so that the Makefile will work across different matlab versions? If not possible, or very difficiult,we'll let this go and make a note in the installation instructions (at teh wiki)

psycharo-zz commented 12 years ago

it is easy, I think it makes sense to pass the path to matlab

ghost commented 12 years ago

How about writing the makefile in matlab as `ffg_builder.m', a bit like this example (https://gist.github.com/4016968 or this one: https://github.com/RomanKosobrodov/mcha/blob/master/Builds/MEX/build_mex.m) that I took from the RealTimeProcessor (at http://www.mathworks.com/matlabcentral/fileexchange/37770-real-time-audio-processor)

psycharo-zz commented 12 years ago

installFactorGraph.m resolves