search

psychobunny / nodebb-plugin-blog-comments

Lets NodeBB act as a comments engine/widget for your blog
BSD 2-Clause "Simplified" License
100 stars 55 forks source link

Blog comments not showing comments (with fix) #81

Closed djensen47 closed 5 years ago

djensen47 commented 5 years ago

Even on the NodeBB blog, the comments are not appearing on the blog post. The only thing that loads is the comment box.

It's because of this line: https://github.com/revir/nodebb-plugin-blog-comments2/blob/master/library.js#L97

It always resolved to false because the value in the database is 0 (not false)

The fix is super simple:

change

return post.deleted === false;

to

return !post.deleted;
djensen47 commented 5 years ago

@barisusakli I'm mentioning you since I'm not sure if @psychobunny is still maintaining this or not.

psychobunny commented 5 years ago

Thanks, I see the PR is on the blog-comments2 version of the plugin, did you want to PR it here as well or should I make the change?

djensen47 commented 5 years ago

Oops. Yeah, I'll take care of that in a bit.

On Mon, Feb 11, 2019, 11:25 AM Andrew Rodrigues <notifications@github.com wrote:

Thanks, I see the PR is on the blog-comments2 version of the plugin, did you want to PR it here as well or should I make the change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/psychobunny/nodebb-plugin-blog-comments/issues/81#issuecomment-462460172, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgN-b8dCp2JvyztlmsPshj5c_76gjlMks5vMcO2gaJpZM4arcQm .