search

psychobunny / nodebb-plugin-desktop-notifications

This NodeBB plugin uses the HTML5 Notifications API to display desktop alerts upon new incoming notifications.
BSD 2-Clause "Simplified" License
19 stars 16 forks source link

Desktop notification banner never goes away #19

Open sorvani opened 9 years ago

sorvani commented 9 years ago

The Mangolassi.it forum uses this plugin and the permission banner ALWAYS pops back up when you force refresh, or come back to the site in a new browser session.

Clicking the X to make it go away does keep it gone for the current browser session.

img

Conversation reference: http://mangolassi.it/topic/6724/nodebb-0-9-0-has-dropped/24

Edit: To clarify, I do not want desktop notifications. So I do not enable them. I would assume for someone with them enabled, they stop seeing that?

psychobunny commented 9 years ago

Hi, yes that's a known limitation at the moment. The problem is if you disable it you have no way to reenable it as you never see the notification again.

I need to add this to the user settings page in order to permanently remove it when you click on the X button. Thanks for reporting!

carlosjs23 commented 8 years ago

When done?

jeffbski commented 8 years ago

It seems like when this is fixed so that it doesn't put the banner up after being dismissed that you could also put something in the user's profile settings so they could re-enable it if they changed their mind.

I think this is a great feature, I hope that it can be fixed soon. I would like to use it but don't want to nag my users if they don't want to use notifications.