search

psychobunny / nodebb-plugin-desktop-notifications

This NodeBB plugin uses the HTML5 Notifications API to display desktop alerts upon new incoming notifications.
BSD 2-Clause "Simplified" License
19 stars 16 forks source link

Request to adapt the plugin to the new versions of nodebb #38

Open A22632 opened 2 years ago

A22632 commented 2 years ago

Request to adapt the plugin to the new versions of nodebb. Thanks.

julianlam commented 2 years ago

Hi @A22632 — is there something non-functional in this plugin? I checked it out and all seems ok. There are no admin pages to update and I think the functionality works fine.

@psychobunny will just need to update nbbpm.compatibility to point append || ^2.0.0

k1r0s commented 10 months ago

@A22632 I've installed the plugin and is not working. Nor is producing any error.

installed from bash: npm install nodebb-plugin-desktop-notifications activated and rebuild.

Nothing happens

k1r0s commented 10 months ago

plugin is not compatible with modern versions, tested with 3.5.5

Uncaught (in promise) TypeError: app.alert is not a function

julianlam commented 10 months ago

Recommend you use ntfy plugin instead. Any reason you want this one?

julianlam commented 10 months ago

I believe that specific error is covered in the v2 migration guide.