psychoinformatics-de / datalad-debian

DataLad extension for working with Debian packages and package repositories
Other
2 stars 5 forks source link

BF: docker bookworm uses deb822 #143

Closed loj closed 1 year ago

loj commented 1 year ago

Unsure if this is an upstream change or an artifact of the debian docker build. All I could find is this discussion:

https://www.mail-archive.com/debian-devel@lists.debian.org/msg370552.html

In any case, bookworm docker images no longer ship /etc/apt/sources.list

codecov-commenter commented 1 year ago

Codecov Report

Merging #143 (b74cb80) into main (b7ecde8) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files          16       16           
  Lines         502      502           
=======================================
  Hits          468      468           
  Misses         34       34           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

adswa commented 1 year ago

This looks sensible, but I don't feel familiar enough with this to recommend relying on my approval alone. I've added this PR into the review queue!

aqw commented 1 year ago

Indeed, starting with Bookworm, Debian is moving towards deb-822. Their official container images ship without /etc/apt/sources.list, but installs via the Debian installer will continue to create /etc/apt/sources.list for now. Eventually, everything will switch over.

loj commented 1 year ago

Thanks for the reviews! Will merge.