Closed bpoldrack closed 1 year ago
Merging #98 (a3373ca) into main (08bc233) will decrease coverage by
0.08%
. The diff coverage is90.00%
.:exclamation: Current head a3373ca differs from pull request most recent head 724a401. Consider uploading reports for the commit 724a401 to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 93.22% 93.14% -0.08%
==========================================
Files 16 16
Lines 487 496 +9
==========================================
+ Hits 454 462 +8
- Misses 33 34 +1
Impacted Files | Coverage Δ | |
---|---|---|
datalad_debian/build_package.py | 89.36% <90.00%> (-0.12%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Given that this PR was approved and I only did a minor review suggestion to use a helper; and the fact that the tests pass, I'll merge this.
Add a marker at the end of the build log for datalad-debian to discover. We want
deb-build-package
's internalcontainers-run
call to come back zero and commit the log, butdeb-build-package
needs to be able to discover and report that something went wrong.In opposition to what's described under 1. in https://github.com/psychoinformatics-de/datalad-debian/issues/39#issuecomment-1181529398, we now get this (returns non-zero):
Not yet unittested