search

psychoinformatics-de / datalad-hirni

DataLad extension for (semi-)automated, reproducible processing of (medical/neuro)imaging data
http://datalad.org
Other
5 stars 8 forks source link

FR: hirni-dicom-import should check --properties argument loading data #139

Open pvavra opened 4 years ago

pvavra commented 4 years ago

Misspecifying the --properties when calling datalad hirni-dicom-import will load the data into the annex, but then fail without producing a studyspec.json file.

I see two alternative solutions: A) the provided properties are sanity-checked before the data are imported and aborting import in case of a misspecification B) After fixing the properties argument, it is possible to "continue" creating the studyspec.json file, without having to re-import the data.

This is relatively important when importing a large tarbar, as this takes time..

pvavra commented 4 years ago

@bpoldrack: I'll be using "FR: " in the title for feature requests - unless you prefer I tag them somehow else. I think, this way the titles are a bit easier to read..

bpoldrack commented 4 years ago

"FR" is fine with me, although in this case I'd even regard that as a bug. It's absolutely true, that this should not be the case. import-dcm is calling dicom2spec after importing the data and passing the properties. This should never lead to unrolling importing step.