search

psychoinformatics-de / datalad-hirni

DataLad extension for (semi-)automated, reproducible processing of (medical/neuro)imaging data
http://datalad.org
Other
5 stars 8 forks source link

dicom2spec doesn't overwrite unique() properties of dicom series #142

Open pvavra opened 4 years ago

pvavra commented 4 years ago

In trying to address #140, I noticed some unexpected behavior:

If a spec files is being overwritten (e.g. when testing new custom rules), and the dicomseries:all part had already a "bids-session":null property, this does not get overwritten, even if all subsequent dicom series share the same value.

Lines 222ff suggest that a mechanism is there for this, but maybe they are not interacting well with overrides a couple of lines above?

can provide access to dicoms / specs on medusa if that helps debugging it..

bpoldrack commented 4 years ago

Hm. Not obvious at a first glance what goes wrong. It should (tm) be overwritten indeed.