Closed bpoldrack closed 4 years ago
Merging #159 into master will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 86.17% 86.20% +0.02%
==========================================
Files 17 17
Lines 955 957 +2
==========================================
+ Hits 823 825 +2
Misses 132 132
Impacted Files | Coverage Δ | |
---|---|---|
datalad_hirni/commands/spec2bids.py | 85.43% <100.00%> (+0.28%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 78455fd...4600f41. Read the comment docs.
So this is strange. Just dropping some snippets here to not forget about them while digging
[INFO] ...>aggregate:370,757>log:297 Finished metadata aggregation into Dataset(/tmp/datalad_temp__single_session_dicom2bids5fgc8gsb)
[INFO] ...>test_dicomconv:56>dataset:498>utils:494,482,413,552>spec2bids:268>utils:413,552>run_procedure:442 Running procedure hirni-dicom-converter
[INFO] ...>run_procedure:452>utils:413,552>run:239,628,460 == Command start (output follows) =====
[INFO] hirni-dicom-converter:114>dataset:498>utils:494,482,413,552>containers_run:138>run:588,343 Making sure inputs are available (this may take some time)
[WARNING] ...>run:588,349>utils:494,482,413,552>get:780,542>gitrepo:328>annexrepo:1352,2358 Running get resulted in stderr output: download failed: Unauthorized
download failed: Unauthorized
download failed: Unauthorized
git-annex: get: 1 failed
[ERROR] ...>utils:494,482,413,588 Remote psydata-store not usable by git-annex; setting annex-ignore [get(/tmp/datalad_temp__single_session_dicom2bids5fgc8gsb/code/hirni-toolbox/converters/heudiconv/heudiconv.simg)]
[INFO] ...>run:628,460 == Command start (output follows) =====
ERROR : Image path code/hirni-toolbox/converters/heudiconv/heudiconv.simg doesn't exist: No such file or directory
ABORT : Retval = 255
[INFO] ...>run:628,488 == Command exit (modification check follows) =====
[INFO] ...>run:699 The command had a non-zero exit code. If this is expected, you can save the changes with 'datalad save -d . -r -F .git/COMMIT_EDITMSG'
spec2bids
don't appear at all. How so?Another note: Within the same test run as above, another conversion succeeds, which needs to get the very same container from the very same source. No "download failed: Unauthorized" there.
Merging #159 into master will decrease coverage by
0.50%
. The diff coverage is56.25%
.
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 86.17% 85.67% -0.51%
==========================================
Files 17 18 +1
Lines 955 970 +15
==========================================
+ Hits 823 831 +8
- Misses 132 139 +7
Impacted Files | Coverage Δ | |
---|---|---|
datalad_hirni/tests/utils.py | 41.66% <41.66%> (ø) |
|
datalad_hirni/commands/spec2bids.py | 85.43% <100.00%> (+0.28%) |
:arrow_up: |
datalad_hirni/tests/test_demos.py | 92.95% <100.00%> (+0.10%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 78455fd...3174bdc. Read the comment docs.
Addressing #158.