psychoinformatics-de / inm-icf-utilities

MIT License
0 stars 5 forks source link

Why does the Singularity definition use git clone instead of copying the files from local repo? #54

Closed mslw closed 3 months ago

mslw commented 4 months ago

The Singularity recipe includes cloning this repo into the image during build. Is there a reason why the git clone route was used?

IMO it would make even more sense to copy files during build, instead of going "the long way round" through GitHub. The only advantage I can see is that with git pull the main branch on psychoinformatics-de GitHub serves as a semi-official "release". A downside is that it is harder to build an image from a local copy which is not published elsewhere.

I didn't check the singularity docs very closely, but it seems the %files section in singularity definition file) could be used instead.

Ping Aswendt-Lab/inm-icf-utilities/pull/2 -- I got reminded of this when we tried to build from a slightly changed fork.