search

psychoinformatics-de / paper-remodnav

Code, data and manuscript for https://doi.org/10.1101/619254
Creative Commons Attribution 4.0 International
4 stars 2 forks source link

BF: Missing subdataset data retrieval #14

Closed adswa closed 4 years ago

adswa commented 4 years ago

This is the underlying cause for what Asim reported in #12: The subdataset data/raw_eyegaze was never properly installed. It only became a problem when one of the functions introduced during the revision required data from this subdataset. In local runs, the data had always been present already, and my previous "reproducible paper" presentations were based on master, where this function was not merged into yet.

adswa commented 4 years ago

attn @mih @ElectronicTeaCup I'll merge this in. this should fix the problem Asim observed in #12. Good thing someone stumbled across it.

adswa commented 4 years ago

(please revert if you disagree with something)

mih commented 4 years ago

Just a comment: The get() you added should imply the install() call you are making explicit. But that is neither a problem nor something that should be changed. Thx!

adswa commented 4 years ago

oh, you are right. thanks, I'll keep it in mind next time. We do want this change to be in the preprint branch, too, right?

mih commented 4 years ago

Yes, would be needed there too.

adswa commented 4 years ago

Cherry-picked and pushed, should be there.