Modernize - Githubissues

psychoinformatics-de / paper-remodnav

Code, data and manuscript for https://doi.org/10.1101/619254

Creative Commons Attribution 4.0 International

4 stars 2 forks source link

Modernize #18

Closed mih closed 3 years ago

mih commented 3 years ago

Just just be a make still, but:

ensure virtual env with proper dependencies and remodnav version
all imports on top (immediate and complete dependency check)
no longer piping outputs (did prevent progress bars from showing)
avoid computing some pieces twice
consolidate datalad API usage on a single function (get)
some more explicit function names
some import duplication removed

adswa commented 3 years ago

EDIT: Disregard this. ~Oh one more thought: remodnav doesn't have datalad as a requirement, as far as I remember. Can we add this, or point people towards installing it themselves?~

adswa commented 3 years ago

I pushed a README update

mih commented 3 years ago

Thx!