Aspects from preprint feedback

psychoinformatics-de / paper-remodnav

Code, data and manuscript for https://doi.org/10.1101/619254

Creative Commons Attribution 4.0 International

4 stars 2 forks source link

Aspects from preprint feedback #7

Closed mih closed 5 years ago

mih commented 5 years ago

data recording requirements (e.g. sampling rate): https://twitter.com/LewisChuang/status/1122450508067823616
eye blink detection: https://twitter.com/ZSjoerds/status/1122216533470666753

Unrelated, but relevant:

how to avoid PNG figured, maybe even plot all data points across all runs and participants: https://twitter.com/michaelwaskom/status/1123285448128901120

adswa commented 5 years ago

I added the rasterized parameter to the mainsequence plotting in ad6b5c647bc0781f570c2c666ea8147ac5675c3c, and it really speeds up rendering, pretty much regardless of the amount of data (only one run or all). When taking all runs in, the content of the figure changes only in the sense that the main sequence looks "fatter"/more overcrowded and the events plotted on top (saccades) superimpose the PSOs more -- thats a bit of an anti-feature. IMO we'd be fine going with only one run.

AsimHDar commented 5 years ago

What other data recording requirements are there for eye scanners exactly? For sampling rate, we've mentioned that there is no set default, and the sampling rates in the two data sets (good quality vs lower quality)— do we need to add anything else?

mih commented 5 years ago

Added some bits