Debianize: PYOSF_FOLDER to .local/share

psychopy / pyosf

A pure python library for simple sync with Open Science Framework

9 stars 5 forks source link

Debianize: PYOSF_FOLDER to .local/share #2

Closed lindemann09 closed 7 years ago

lindemann09 commented 7 years ago

Just a minor thing: Under Debian/Linux PYOSF_FOLDER should be under ~/.local/share/...

peircej commented 7 years ago

Hmm, I see there's this xdg spec telling us to use that but on my ubuntu box ~/.local/share is mostly folders of OS-level tools (icons, keyrings, nautilus, unity settings) and most app-specific settings (thunderbird, ssh, gnupg, ipython, spyder...) are still in ~/.* folders.

peircej commented 7 years ago

Ah, it looks like packages (e.g. ssh and gnupg) are just being slow to make the switch. OK, next issues:

we're using this file to store a key to access the OSF on behalf of the user. That key shouldn't be accessible to other users of the machine but the name ".local/share" suggests that it is, but the permissions say "share" is only open to the user. Misnomer? Therefore OK?
some people have already used this package and I don't want to break their existing stored data (e.g. previous sync) so we should check whether ~/.pyosf exists and either move it or use it in place

codecov-io commented 7 years ago

Current coverage is 89.70% (diff: 75.00%)

Merging #2 into master will decrease coverage by 0.30%

@@             master         #2   diff @@
==========================================
  Files            10         10          
  Lines          1241       1243     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1117       1115     -2   
- Misses          124        128     +4   
  Partials          0          0

Powered by Codecov. Last update d1dd9da...7e545d3