Nick highlighting is too general.

psychs / limechat

IRC Client for Mac

http://limechat.net/mac/

1.55k stars 266 forks source link

Nick highlighting is too general. #293

Open dmtucker opened 8 years ago

dmtucker commented 8 years ago

On Freenode, I go by dtux. I woke up to a bunch of notifications this morning from people mentioning someone else that goes by re_dtux_edocash. Seems like that probably shouldn't happen...

edit: 2018-03-29 Still happens (reproduced with just redtuxedo)

kengruven commented 3 years ago

It looks like the relevant section is in LogRenderer.m, at the loop for (NSString* keyword in keywords).

Right now, it does a simple -rangeOfString:options:range with NSCaseInsensitiveSearch.

An improved version could use an NSRegularExpression, running -escapedPatternForString on the keyword, and surrounding it with something like \b.