psyho / bogus

Fake library for Ruby
Other
359 stars 14 forks source link

Minitest support #5

Closed chastell closed 11 years ago

chastell commented 11 years ago

I’m not sure whether there’s a sane way of testing the minitest support code with RSpec, but the Cucumber features do cover all of it. Please let me know whether to clarify/expand/split them if needed. :)

Missing, but can wait for another PR: verify_contract support; mintest doesn’t have described_class, so I’ll have to figure out how to implement it.

wrozka commented 11 years ago

Thanks. We would love to see minitest support. If you add cucumber features and specs, we'll be glad to merge it.

BTW, we again switched to automatic requires, remember to exclude minitest the same way as rspec.

chastell commented 11 years ago

Awesome, I’ll work on this, then (probably not before the weekend, though). Title-tagged as ‘work in progress’ for now.

coveralls commented 11 years ago

Coverage Status

Coverage decreased (-0%) when pulling 83a117d3f7d16ab0a87792cb3e82c7f4acaaf695 on chastell:minitest_support into 6945a0be150f273e4b69c4733fb62dbe056c3636 on psyho:master.

coveralls commented 11 years ago

Coverage Status

Coverage decreased (-0%) when pulling 92f642cf94baa37e2a52e89e950638f2ed13dc7a on chastell:minitest_support into 6945a0be150f273e4b69c4733fb62dbe056c3636 on psyho:master.

chastell commented 11 years ago

(I’m still working on this and should finisish soon, hopefully this weekend. Struggling with Cucumber a bit.)

chastell commented 11 years ago

I tracked it down to https://github.com/cucumber/cucumber/pull/456 – I’ll have a working PR as soon as Cucumber 1.3.3 is released (I pinged the maintainers).

tooky commented 11 years ago

@chastell we released cucumber 1.3.3 over the weekend

chastell commented 11 years ago

Can somebody take a look at this tell me where to go with the cucumber features? I feel they need more work (and I’m happy to do it), but I’d love to get some guidance. :)

I’d love for this to be merged in once the features are ironed out (and I’ll work on verify_contract support separately).

wrozka commented 11 years ago

I've rebased your changes on top the master. Thank you. Good luck with verify_contract. ;)

chastell commented 11 years ago

\o/ Thanks! verify_contract (via a custom described_class) is doable, it’ll just take some time.