psyinfra / HTCAnalyze

MIT License
0 stars 3 forks source link

Add unhandled events #139

Closed mathisloevenich closed 2 years ago

mathisloevenich commented 2 years ago

fixes partly #127

Within the testset of ukb, enki and git htcondor logs, all events are handled.

The problem is that the documentation about how to access address each event individually is missing and there is no python baseclass to extract the information from. From what I understand is that the python structure is translated directly from the C++ base module, which has a total different setup and makes it hard to known where which part of the information is comming from.

Each event has a different struture which means each event needs to be handled differently.

There are base classes for the following event numbers that come with this PR:

Not (yet) handled events (regarding the base classes) are:

And obviously all other events not mentioned here need also to be implemented

codecov-commenter commented 2 years ago

Codecov Report

Merging #139 (e034c16) into master (63769d8) will increase coverage by 0.62%. The diff coverage is 39.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   47.56%   48.19%   +0.62%     
==========================================
  Files          32       32              
  Lines        1337     1413      +76     
  Branches      148      152       +4     
==========================================
+ Hits          636      681      +45     
- Misses        693      724      +31     
  Partials        8        8              
Impacted Files Coverage Δ
htcanalyze/log_analyzer/condor_log/ram_history.py 27.58% <0.00%> (ø)
...nalyze/log_analyzer/event_handler/event_handler.py 30.87% <28.57%> (+4.32%) :arrow_up:
htcanalyze/log_analyzer/event_handler/states.py 63.75% <50.00%> (+4.32%) :arrow_up:
...tcanalyze/log_analyzer/event_handler/job_events.py 57.47% <57.14%> (+4.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63769d8...e034c16. Read the comment docs.