psyinfra / onyo

text-based inventory system on top of git
ISC License
3 stars 5 forks source link

`onyo get` returns `<unset>` rather than `false` for `is_asset_directory` #578

Closed aqw closed 6 months ago

aqw commented 6 months ago

In my opinion, onyo get is misleading by returning <unset> rather than false for asset files.

The pseudo key isn't unset, rather we /know/ that indeed this asset is not an Asset Directory.

❱ onyo get --keys is_asset_directory --path accounting
 ─────────────────────────────────────────────────────────────────────────── 
  is_asset_directory   path                                                  
 ─────────────────────────────────────────────────────────────────────────── 
  <unset>              accounting/Bingo Bob/laptop_apple_macbook.oiw629      
  <unset>              accounting/Bingo Bob/monitor_dell_PH123.86JZho        
  True                 accounting/Bingo Bob/headphones_apple_airpods.uzl8e1  
 ───────────────────────────────────────────────────────────────────────────