Closed aqw closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.70%. Comparing base (
dc2348d
) to head (a68ded3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This implementation mimics the original behavior, while fixing two bugs:
onyo tree
now prints from CWD (as documented) rather than repository root. Theonyo_tree
function still defaults to repository root.By using pure Python, we gain flexibility to add Onyo-specific features (perhaps asset highlighting, etc) and also drop a dependency (albeit a common one).
We never allowed passing flags to
tree
, so there really is no loss in functionality.I did some primitive performance tests.
In the "normal" use case, where someone prints a tree of a size that a human can reasonably read, the performance hit is negligible.
However, large trees do suffer from a noticeable performance impact. This can be dropped to 0.43s if all output is printed at once.