Closed aqw closed 6 months ago
Attention: Patch coverage is 95.40230%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 96.56%. Comparing base (
9a6d9af
) to head (4713fc0
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
onyo/lib/utils.py | 89.47% | 2 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review!
I've addressed your comments. The only open one is about the voice. But I feel comfortable with the idea that only the short summary needs to be in the imperative.
Thanks a lot :)
I am fine with it all, and regarding the voice: It works obviously either way, it was just hard not to notice while reading trough it all.
From my side this PR can be merged as soon as the tests ran successfully :)
Thanks!
Ideally, I will wait for Ben to review this. Specifically my changes to yaml_to_dict()
and write_asset_file()
.
Buuut we'll see if that responsibility survives the weekend. ;-)
Thanks again for your review!
I talked with Ben yesterday and got an in-person +1 to merge. :-)
This PR is again eclectic, but is finally beginning to turn the corner to focus more on docstrings.
The PR includes:
assets.py
intoutils.py
Asset
type (which was just adict
)yaml_to_dict()
->get_asset_content()
dict_to_yaml()
->dict_to_asset_yaml()
utils.py
and constants inconsts.py
write_asset_file()
TYPE_CHECKING
blocksWhen documenting the constants, I intentionally did not wade into the issue of resolving the clear discrepancy of the names of PSEUDO_KEYS and RESERVED_KEYS vs how they are used. That is on my TODO list, but looks to be a complicated mess to unravel.