remove `--rename` from `onyo set`

[aqw]

I'm not 100% sold on this, but I might be coming around to Ben's argument from long ago. (Paraphrasing):

What is the difference between a commit (or set) that changes key values, versus a commit that changes key values that result in a rename.

And now that I am using Onyo in reality... I can't say that I feel a difference.

I wanted to make consistent some variances in capitalization:

❱ onyo get --keys make -s make | uniq
 ─────────────── 
  make           
 ─────────────── 
  apple
  ctouch
  dasgip
  dell
  Dell
  delta
  eizo
  Eizo
...

So I filtered for it and piped into onyo set.

❱ onyo get -H --match make=Eizo --keys path | xargs -d "\n" onyo --yes set --keys make=eizo --rename --asset

Taking a look at the onyo set flags:

• --yes: needed to respond yes to UI prompts
• --keys: the actual data being set
• --rename: all setting a field that would result in a file rename
• --asset: the list of assets to operate on

All of the flags seems necessary and obvious except for --rename. It's guarding against... a mistake? Signaling to the user that the field they're setting is "more important" than other fields. Which doesn't hold, as useless information can be used for fields in the file name.

In short, I think we should remove --rename. I'm interested in your thoughts.

[aqw]

A conversation on Matrix resulted in a consensus that --rename should be retired.

Points made:

• onyo edit renames assets without --rename (consistency FTW)
• asset names are user-defined; nothing says the keys used are any more important than other keys
• diffs are produced for everything