search

psyinfra / onyo

text-based inventory system on top of git
ISC License
3 stars 5 forks source link

Simplify Filter.match #687

Closed bpoldrack closed 1 month ago

bpoldrack commented 1 month ago

There's no functional change in this patch. Just refactoring the code to be a bit simpler, slightly more efficient and (most importantly) a little easier to read and maintain. Previous version of the implementation was a bit convoluted as pointed out in https://github.com/psyinfra/onyo/pull/668#discussion_r1798456545

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.24%. Comparing base (5c4c291) to head (10d2e21). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #687 +/- ## ========================================== + Coverage 96.20% 96.24% +0.03% ========================================== Files 68 68 Lines 6080 6091 +11 Branches 514 514 ========================================== + Hits 5849 5862 +13 + Misses 139 138 -1 + Partials 92 91 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aqw commented 1 month ago

We will merge this after #668

aqw commented 1 month ago

I spoke too soon. Tests seem to fail.

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit 10d2e21c and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.