psyinfra / onyo

text-based inventory system on top of git
ISC License
3 stars 5 forks source link

New Feature: `onyo.` namespace for Pseudo Keys #688

Open aqw opened 1 month ago

aqw commented 1 month ago

All Pseudo Keys, now and in the future, should live under the onyo. namespace. See #678 for design background.

New Structure:

Retired:

Note:

Future (out of scope for this issue; just context):

aqw commented 1 month ago

While writing this, it became apparent that we overlooked onyo.template in the design phase. It is very clearly the odd one out. It has no value beyond onyo new, and could never be queryable.

What about something like onyo.new.template (or onyo.new.--template or...). Or maybe onyo.cli.--template (and make `onyo.cli. a generic namespace to call flags)?

Ideas are most welcome here.

aqw commented 1 month ago

I have created #692 to allow onyo new to temporarily override onyo configuration key values. That solves the onyo.template problem.

bpoldrack commented 3 weeks ago

I like this approach. Want to throw in one more thing, though: onyo.is.template. This isn't actually related to the template "key" you mentioned above, but to #675.

aqw commented 3 weeks ago

Yup! This issue I intentionally omits keys for new features. There is an onyo.is.template in #675

bpoldrack commented 1 week ago

Generally, I do support the idea of onyo.cli.template. I wouldn't put in the --, though. While it's a reference to a command option, the weirdness of onyo.cli.--template isn't necessary and furthermore: There is a difference in behavior. Such keys would be meant to specify per-asset options. Which is different from the switch itself, which refers to the entire command.