psyinfra / onyo

text-based inventory system on top of git
ISC License
3 stars 5 forks source link

Getting rid of YAML implicit typing (for now) #707

Closed bpoldrack closed 1 day ago

bpoldrack commented 3 weeks ago

See commit message.

This is essentially ready, but: It wouldn't be ready for a release or actual usage (which speaks to a lack of testing). The reason is the is_asset_directory key, which is expected to be a boolean rather than a string. But with this PR, users can't easily pass a boolean anymore. However, the clean solution for that, would rely on a proper implementation of pseudo keys in general, so I'd prefer to solve the problem in that PR rather than here.

Closes #696 Closes #643 Closes #261

codeclimate[bot] commented 3 weeks ago

Code Climate has analyzed commit 5ea72fdd and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.38%. Comparing base (fb63ddd) to head (b8a415b). Report is 36 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #707 +/- ## ========================================== + Coverage 96.22% 96.38% +0.15% ========================================== Files 69 69 Lines 6098 6113 +15 Branches 527 526 -1 ========================================== + Hits 5868 5892 +24 + Misses 136 132 -4 + Partials 94 89 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

aqw commented 2 weeks ago

Ahh, I forgot to also mention, this PR may also address the following two issues: