Open bpoldrack opened 2 days ago
Attention: Patch coverage is 95.93023%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 94.60%. Comparing base (
b8a415b
) to head (402b7c7
). Report is 17 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Sits on top of PR #707 and resolves its issue WRT
is_asset_directory
by removing that key altogether. This is now split into the newonyo.is.asset
andonyo.is.directory
pseudo-keys. Although for the most partonyo.is.directory
is what is used instead.This is the first PR of a series, aiming to implement #662, #688, #689. It's introducing an
Item
class and a newPSEUDO_KEYS
mapping, that add pseudo-keys to dict-likes. The aim for this PR is:path
anddirectory
keys aliases and replace their internal usage (except for test code, where they are still used at times in their role as default aliases)is_asset_directory
key in favor ofonyo.is.directory
(andonyo.is.asset
)DotNotationWrapper
byItem
in most places.DotNotationWrapper
remains valid in some places where we don't want any pseudo-keys yet (For example: Reading yaml from an edited temporary file - only becomes anItem
when we tie it to the actual repo. We don't want pseudo-keys referring to the temp file)is_asset_directory
while throwing this class in.Item
's ability to represent directories, templates, etc. - just assets in the first round.The scope is limited, in order to address that topic in digestable chunks. Next up should be:
Item
consistently for anything at high-level code, so this becomes the datastructure, thatInventory
and command implementations deal with, instead of arbitrary dicts and paths.get
to query anything (dirs, templates)During these further steps, we/I can figure out additional functions to ease various ways of dealing with these objects (we need to repeatedly strip or reset pseudo-keys and we have notions of "you-can't-set-these", leading to a bunch of code duplication - I want to iron that out as we get to see more access patterns)