psyplot / psy-maps

The psyplot plugin for visualizations on a map
https://psyplot.github.io/psy-maps
8 stars 5 forks source link

make false_easting and false_northing optional #41

Closed Chilipp closed 2 years ago

Chilipp commented 2 years ago

this second part fixes the visualization of the lambert conformal grid in psyplot/psyplot#38. The current implementation assumed the false_easting and false_northing attributes to be mandatory, although they should be optional.

codecov[bot] commented 2 years ago

Codecov Report

Merging #41 (af0401e) into develop (aa2de37) will increase coverage by 0.04%. The diff coverage is 93.54%.

:exclamation: Current head af0401e differs from pull request most recent head 486a6c0. Consider uploading reports for the commit 486a6c0 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #41      +/-   ##
===========================================
+ Coverage    78.36%   78.41%   +0.04%     
===========================================
  Files            6        6              
  Lines         1336     1348      +12     
===========================================
+ Hits          1047     1057      +10     
- Misses         289      291       +2     
Impacted Files Coverage Δ
psy_maps/plotters.py 85.39% <93.54%> (-0.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa2de37...486a6c0. Read the comment docs.