psyplot / psy-maps

The psyplot plugin for visualizations on a map
https://psyplot.github.io/psy-maps
8 stars 5 forks source link

add target_extent for mapdensity #44

Closed Chilipp closed 2 years ago

Chilipp commented 2 years ago

This PR implements a fix for #43 (ping @victoria-cherkas). The quiver method of cartopy takes atarget_extent keyword that defaults to the map projection limits (which is by default global in the beginning).

        target_extent: 4-tuple
            If given, specifies the extent in the target CRS that the
            regular grid defined by *regrid_shape* will have. Defaults
            to the current extent of the map projection.

We did not specify this, which it is why the quiver collection has a global datalimit. This PR should fix this

closes #43

codecov[bot] commented 2 years ago

Codecov Report

Merging #44 (ece92c0) into develop (9b7dad4) will increase coverage by 0.14%. The diff coverage is 94.11%.

@@             Coverage Diff             @@
##           develop      #44      +/-   ##
===========================================
+ Coverage    78.41%   78.55%   +0.14%     
===========================================
  Files            6        6              
  Lines         1348     1357       +9     
===========================================
+ Hits          1057     1066       +9     
  Misses         291      291              
Impacted Files Coverage Δ
psy_maps/plotters.py 85.51% <94.11%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b7dad4...ece92c0. Read the comment docs.