search

psyplot / psy-simple

psy-simple: The psyplot plugin for simple visualizations
https://psyplot.github.io/psy-simple
1 stars 3 forks source link

Do not use matplotlib for testing contains #18

Closed Chilipp closed 4 years ago

Chilipp commented 4 years ago

Extracting the coordinates using the method from #17 is incredibly low. This PR reverts the changes and instead of using the matplotlib artist to test if it contains the event, we calculate the maximum distance in x and y, and if the distance to the closest grid cell is larger than this maximum dist, we do not use it

codecov-commenter commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1f1fa26). Click here to learn what that means. The diff coverage is 3.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   83.10%           
=========================================
  Files             ?        9           
  Lines             ?     4766           
  Branches          ?        0           
=========================================
  Hits              ?     3961           
  Misses            ?      805           
  Partials          ?        0
Impacted Files Coverage Δ
psy_simple/plotters.py 83.28% <3.84%> (ø)
psy_simple/widgets/__init__.py 100.00% <0.00%> (ø)
psy_simple/widgets/texts.py 87.61% <0.00%> (ø)
psy_simple/widgets/colors.py 80.78% <0.00%> (ø)
psy_simple/__init__.py 100.00% <0.00%> (ø)
psy_simple/colors.py 81.72% <0.00%> (ø)
psy_simple/version.py 100.00% <0.00%> (ø)
psy_simple/plugin.py 77.71% <0.00%> (ø)
psy_simple/base.py 87.62% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f1fa26...ac8f508. Read the comment docs.