Closed Chilipp closed 4 years ago
Merging #22 into master will increase coverage by
0.91%
. The diff coverage is15.30%
.
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 61.80% 62.71% +0.91%
==========================================
Files 8 8
Lines 1733 1719 -14
==========================================
+ Hits 1071 1078 +7
+ Misses 662 641 -21
Impacted Files | Coverage Δ | |
---|---|---|
psy_view/plotmethods.py | 81.99% <0.00%> (ø) |
|
psy_view/dialogs.py | 11.57% <15.46%> (+2.05%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ade6622...8ffe4c9. Read the comment docs.
Great work! It does look nice and it quite intuitive to use, so I would consider it done. I though for a moment about the fact that the displayed colorbar is unchanged and the labels (and maps of course) adapt to the scaling as opposed to ncview where the colorbar changes while the labels stay static. I'd say ncview is more intuitive here at first, but when you want plots which are easier to analyse, your way very much helps to actually relate the color you are seeing to a specific number. Thus, I would stick to it.
Thanks for the feedback @tobstac! :) My plan was anyway to also add an option for the colorbar ticks. Then you can fix the. The default at the moment is to let matplotlib choose the default, and this varies of course depending on the norm you use
Hey @tobstac, @StefanHagemann and @psyplot/psyplot-hzg in general! I revised the color settings dialog (and more) and it would be nice if you could give it a try here: . @StefanHagemann: is this easy enough for the range option you mentioned?
Unfortunately, mybinder did not recreate a new container but uses the outdated version of psy-simple, etc. Therefore, as soon as you see the desktop, open the terminal by clicking on the button at the bottom and type
conda update -c psyplot/label/bounds-dialog psy-simple psy-maps -y
When this has finished, please open one of the netCDF files. It would be nice to get your feedback on the color options, and whether this is intuitive and rich enough
Note: You can actually also edit the individual colors of a colormap now to customize it more. Just click the Edit button in the color settings dialog and double-click a color to edit it
That's really nice progress! I just played around with your new colormap and ticks options and I've seen every last level of detail can be controlled to produce any kind of colormap scaling with correspondent ticks. I have the impression that the automatic bounds and scalings work best in the linear case but I don't mind having to do some typing for special custom colormaps. So thanks a lot, in my opinion its perfect!
This commit revises the color settings dialog and uses the bounds formatoption dialog. We additionally added a live-updating preview of the resulting colorbar
@tobstac: It would be nice of you could have a look at it on mybinder and give me some feedback :smiley: I also added a discrete logarithmic option
This PR integrates with https://github.com/psyplot/psy-simple/pull/14
Closes #7