search

psyplot / psy-view

An ncview-like GUI with psyplot
https://psyplot.github.io/psy-view
17 stars 2 forks source link

Presets #33

Closed Chilipp closed 4 years ago

Chilipp commented 4 years ago

closes #3

This PR builds upon psyplot/psyplot#24 and psyplot/psyplot-gui#17 and implements the preset functionality into psy-view. We add a tool-button with a menu to save and load the current plot settings as a preset image

Chilipp commented 4 years ago

Hey @psyplot/psyplot-hzg, I'd highly appreciate some quick feedback on the presets option before I merge this into the master branch and install it on mistral, etc.. Would you have time to do so?

Just

  1. click on Binder
  2. as soon as you see the desktop, open one of the netCDF files (double-click icon-test.nc for instance)
  3. make a plot of a variable, t2m for instance
  4. load a preset with the Preset button (see screenshot in the comment above, one preset is already preset installed: EUR-temperature.
  5. Tell me what you think :smiley:
tobstac commented 4 years ago

I just tried it. The functionality seems to work fine and it is definitely a useful feature. However, it seems to open_directory icon in the psy-view GUI (upper right) has been replaced by a red cross which is somewhat counter-intuitive. Also I expected the names of the colormap and projection to change when loading a preset, however, it still showed the standard colormap name even though the preset used another. Might be nice if this information could be made consistent.

Chilipp commented 4 years ago

thanks @tobstac!

However, it seems to open_directory icon in the psy-view GUI (upper right) has been replaced by a red cross which is somewhat counter-intuitive.

Not sure, what you mean exactly. Can you make a screenshot and paste it here?

Also I expected the names of the colormap and projection to change when loading a preset, however, it still showed the standard colormap name even though the preset used another. Might be nice if this information could be made consistent.

True, I'll implement this, thanks for spotting it :sweat_smile:

Chilipp commented 4 years ago

ah, is it this one @tobstac? image Yes, the red cross should actually be hidden on the start

Chilipp commented 4 years ago

ok, sollte jetzt funktionieren @tobstac

Binder

tobstac commented 4 years ago

Not sure, what you mean exactly. Can you make a screenshot and paste it here?

psyview

The one at the upper right corner. I think up to now there was a small directory symbol there.

Chilipp commented 4 years ago

oh thanks! This happened in a22db85e172fd3ca5c62b3d4607c0bbcb2d1a0ec, no clue why. I'll fix it

Chilipp commented 4 years ago

done with 2989627 @tobstac

Binder

any more comments?

tobstac commented 4 years ago

Nope, seems all shiny to me. As I said, nice new feature :+1: