pszklarska / beacon_broadcast

A Flutter plugin for turning your device into a beacon.
https://pub.dartlang.org/packages/beacon_broadcast/
MIT License
81 stars 33 forks source link

AltBeacon Library Update #33

Closed praveen-gm closed 2 years ago

praveen-gm commented 2 years ago
pszklarska commented 2 years ago

Hi @praveen-gm! Thank you for your PR and I'm sorry for the delay.

It looks good to me. However, there were some issues with the CI. It should be fixed by now, but GitHub Actions won't allow me to re-run it (as it's been more than 30 days), so can you please update your PR and push your changes again to trigger the CI?

codecov-commenter commented 2 years ago

Codecov Report

Merging #33 (14cb00e) into master (4613f3f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files           1        1           
  Lines          63       63           
=======================================
  Hits           59       59           
  Misses          4        4           

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

praveen-gm commented 2 years ago

Hi @pszklarska, I've updated my PR to trigger the CI. It looks like the Pre-publishing failed due to missing credentials. Let me know if there's anything else.

pszklarska commented 2 years ago

Awesome, thanks @praveen-gm! I fixed this issue with CI, so all you have to do now is to fix one conflict in the example/pubspec.lock and I'd be happy to merge your PR!

praveen-gm commented 2 years ago

@pszklarska, I've pulled the changes from master and resolved conflicts at example/pubspec.lock