search

pszufe / OpenStreetMapX.jl

OpenStreetMap (*.osm) support for Julia 1.0 and up
MIT License
118 stars 24 forks source link

Bump LibExpat for LibExpat_jll binary support #60

Closed jeremiahpslewis closed 2 years ago

pszufe commented 2 years ago

Hi, thanks for that, however unit tests for ProtoBuf are failing ugly after this update. Could you have a look? https://app.travis-ci.com/github/pszufe/OpenStreetMapX.jl/jobs/560852995

jeremiahpslewis commented 2 years ago

@pszufe thanks for the feedback! In order to keep this PR focused on libexpat (and given that after looking into the protobuf issue, the fix seems extensive and unfamiliar), I've dropped the version bump on protobuf

jeremiahpslewis commented 2 years ago

Note: although this isn't expressly covered by the project CI, the PR passed on Mac OS Apple Silicon, Julia 1.7 :)

pszufe commented 2 years ago

I used to run Travis on MacOS. However at some point they change the rules. Now there is credit budget for Open Source projects for CI. The problem is that MacOS eats 20x as much of budget as Linux. So when I run CI on MacOS I end up not being able to run Travis unit tests at all. Thanks for the PR!

jeremiahpslewis commented 2 years ago

Thank you for the quick review and merge! :)